Use alternative hover and active on dark Cards #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let users specify if card has a dark background color. If true the interaction states :hover and :active will be lighter and louder instead of the default "make it darker" and "less loud" (more subtle effect).
github-actions
bot
temporarily deployed
to
pr-2443-card-expose-options
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2443
What is the new behavior?
This enhancement lets users specify if card has a dark background color. If true the interaction states :hover and :active will be lighter and louder instead of the default "make it darker" and and more subtle "less loud".
Disclaimer: This is almost a one-off thing and the implementation does not allow for any flexibility. It's either or. Users also has to apply the property themselves - it does not apply automagically.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Make sure you have implemented tests following the guidelines in: "The good: Test".Review
When the pull request has been approved it will be merged to
developby Team Kirby.