Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♿️ Make button interactive instead of host element #2486

Closed
wants to merge 17 commits into from
Closed

♿️ Make button interactive instead of host element #2486

wants to merge 17 commits into from

Conversation

jkaltoft
Copy link
Collaborator

@jkaltoft jkaltoft commented Sep 19, 2022 •
edited
Loading

Which issue does this PR close?

This PR closes #2477

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jkaltoft jkaltoft force-pushed the bug/2477-dropdown-focus branch 3 times, most recently from 749bc7d to b5789b5 Compare September 22, 2022 11:00
@jkaltoft jkaltoft force-pushed the bug/2477-dropdown-focus branch from b5789b5 to 54053ca Compare September 28, 2022 09:34
@github-actions github-actions bot temporarily deployed to pr-2477-dropdown-focus September 28, 2022 09:38 Inactive
@jkaltoft jkaltoft force-pushed the bug/2477-dropdown-focus branch from 54053ca to 1527949 Compare September 29, 2022 07:57
@github-actions github-actions bot temporarily deployed to pr-2477-dropdown-focus September 29, 2022 08:01 Inactive
@jkaltoft jkaltoft force-pushed the bug/2477-dropdown-focus branch from 1527949 to 8b125d6 Compare September 29, 2022 14:42
@jkaltoft jkaltoft changed the base branch from develop to feature/2342-dropdown-keyboard-navigation October 3, 2022 14:04
@jkaltoft jkaltoft changed the base branch from feature/2342-dropdown-keyboard-navigation to develop October 3, 2022 14:05
@github-actions github-actions bot temporarily deployed to pr-2477-dropdown-focus October 3, 2022 14:55 Inactive
@jkaltoft
Enable tests again
492e501 
Some (appearently) unrelated tests were excluded.
They are now enabled again.
@github-actions github-actions bot temporarily deployed to pr-2477-dropdown-focus October 4, 2022 12:14 Inactive
@github-actions github-actions bot temporarily deployed to pr-2477-dropdown-focus October 4, 2022 13:23 Inactive
@jkaltoft jkaltoft mentioned this pull request Oct 5, 2022
Closed
11 tasks
@github-actions github-actions bot temporarily deployed to pr-2477-dropdown-focus October 7, 2022 07:16 Inactive
@github-actions github-actions bot temporarily deployed to pr-2477-dropdown-focus October 7, 2022 11:22 Inactive
@github-actions github-actions bot temporarily deployed to pr-2477-dropdown-focus October 10, 2022 10:50 Inactive
@mark-drastrup
Copy link
Contributor

@jkaltoft I think we can close this PR after #2544 was merged, right?

@jkaltoft
Copy link
Collaborator Author

@jkaltoft I think we can close this PR after #2544 was merged, right?

Yes, I think so.

@jkaltoft jkaltoft closed this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Dropdown focus state
2 participants
@jkaltoft @mark-drastrup