-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/local navigation #2501
Feature/local navigation #2501
Conversation
3083473
to
d686cb6
Compare
I'm on vacation next week so I've approved the changes in advance 🙂 If you have any questions or comments we can follow up on it the week after next week. |
Theres a bit more too it than just breaking constraints. The selected bottom border itself needs to have rounded corners (on all four), which is also part of the reason that it is not "just" a bottom border. |
Nice find. I won't reference something i did not see or base my solution on though. But i can extend the explanation a bit :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, Rasmus 👍🏻
The only thing left is to undo bumping the version number.
From code owner suggestion Co-authored-by: Jesper Kaltoft Vind <git@jesperkaltoft.dk>
UX/UI review is OK! |
Which issue does this PR close?
This PR closes #2186
What is the new behavior?
Added two new experimental features.
[kirbyPageStickyContent]
which allows custom content to be inserted between the kirby-page-title and the kirby-page-content. That will become fixed beneath the ion-header, when scrolling to its intersection point.<kirby-page-local-navigation>
that can be used in conjunction with the new kirby-page directive.Other:
KirbyExperimentalModule
in the designsystem has been introduced in which experimental components can be declared and exposed.ExperimentalExamplesModule
along with a new route/examples/experimental/[path-to-experiment]
has been introduced in the cookbook app in which experimental features can be created and viewed (the new route does not have a ui link)Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.