Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show an alert before dismissing modal #2514

Merged
merged 14 commits into from
Oct 24, 2022

Conversation

mark-drastrup
Copy link
Contributor

Which issue does this PR close?

This PR closes #376

What is the new behavior?

It's now possible to pass an alert config as an optional 3rd argument to the modalController.showModal method. This will trigger an alert, when the user tries to close a modal and make them confirm whether or not it should be closed.

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-376-modal-alert-before-close October 3, 2022 09:06 Inactive
@github-actions github-actions bot temporarily deployed to pr-376-modal-alert-before-close October 3, 2022 09:08 Inactive
@github-actions github-actions bot temporarily deployed to pr-376-modal-alert-before-close October 3, 2022 09:16 Inactive
@github-actions github-actions bot temporarily deployed to pr-376-modal-alert-before-close October 6, 2022 11:32 Inactive
@github-actions github-actions bot temporarily deployed to pr-376-modal-alert-before-close October 12, 2022 12:33 Inactive
@github-actions github-actions bot temporarily deployed to pr-376-modal-alert-before-close October 14, 2022 11:13 Inactive
@mictro mictro self-requested a review October 24, 2022 07:29
Copy link
Contributor

@mictro mictro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download

@mark-drastrup mark-drastrup merged commit 96ac460 into develop Oct 24, 2022
@mark-drastrup mark-drastrup deleted the enhancement/376-modal-alert-before-close branch October 24, 2022 12:29
@RasmusKjeldgaard RasmusKjeldgaard mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Modal: Alert before close
2 participants