Affix functionality for formfield #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspringborg
changed the title
7 tasks
github-actions
bot
temporarily deployed
to
pr-form-field-affix-functionality
…inputs.shared.scss. Trying to correctly calculate horizontal padding on input field iwth affix
We should use the input content child in ngAfterContentInit to make sure it is initialized. The inputElement that was used is queried in ngAfterContentChecked, and thus too late.
github-actions
bot
temporarily deployed
to
pr-form-field-affix-functionality
It will just be an empty array if no elements are queried.
github-actions
bot
temporarily deployed
to
pr-form-field-affix-functionality
github-actions
bot
temporarily deployed
to
pr-form-field-affix-functionality
github-actions
bot
temporarily deployed
to
pr-form-field-affix-functionality
tspringborg
commented
Oct 14, 2022
libs/designsystem/src/lib/components/form-field/form-field.component.spec.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
pr-form-field-affix-functionality
RasmusKjeldgaard
approved these changes
Oct 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #459
What is the new behavior?
Formfield now has 2 new selects in it's slotted input template, prefix and suffix.
Does this PR introduce a breaking change?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.