Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: fix z-index for overlayed card #3728

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

RasmusKjeldgaard
Copy link
Collaborator

Which issue does this PR close?

This PR closes #3725

What is the new behavior?

Card is displayed on top of other content when dropdown is opened.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label Nov 28, 2024
@github-actions github-actions bot temporarily deployed to pr-3725-dropdown-transparent-bg November 28, 2024 15:49 Inactive
@github-actions github-actions bot temporarily deployed to pr-3725-dropdown-transparent-bg November 28, 2024 21:40 Inactive
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@RasmusKjeldgaard RasmusKjeldgaard merged commit a8a60e1 into develop Nov 29, 2024
11 of 12 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/3725-dropdown-transparent-bg branch November 29, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Opened dropdown have transparent background
2 participants