Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move all interactive keyboard code to dedicated interactive folder (Android) #353

Merged
merged 12 commits into from
Feb 4, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Feb 4, 2024

📜 Description

Move all interactive keyboard code to dedicated interactive folder/package in kotlin/Android.

💡 Motivation and Context

Ideally in root android folder I'd like to keep a single package file and all other code should be placed in folders.

Initially I created generic purpose folders, like events/listeners/views etc. However sometimes it may be hard to create generic purpose folders for specific files. Theoretically I could create folders controllers/providers, but they would contain only single files.

So I took an inspiration from #346 PR, where I created traversal folder for keeping functionality related to view traversal/keyboard toolbar. And in this PR I moved all interactive-keyboard related code into interactive folder - it keeps file-system clean 😎

📢 Changelog

CI

  • free up disk for e2e tests (Android);

Android

  • added interactive folder;
  • move interpolators folder to interactive;
  • moved InteractiveKeyboardProvider and KeyboardAnimationController to interactive folder.

🤔 How Has This Been Tested?

Tested on CI.

📸 Screenshots (if appropriate):

Before After
image image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added 🤖 android Android specific refactor You changed the code but it didn't affect functionality 👆 interactive keyboard Anything related to interactive keyboard dismissing labels Feb 4, 2024
@kirillzyusko kirillzyusko self-assigned this Feb 4, 2024
Copy link
Contributor

github-actions bot commented Feb 4, 2024

📊 Package size report

Current size Target Size Difference
116017 bytes 115998 bytes 19 bytes 📈

@kirillzyusko kirillzyusko marked this pull request as ready for review February 4, 2024 15:47
@kirillzyusko kirillzyusko merged commit a70c6fd into main Feb 4, 2024
12 checks passed
@kirillzyusko kirillzyusko deleted the refactor/interactive-folder-android branch February 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific 👆 interactive keyboard Anything related to interactive keyboard dismissing refactor You changed the code but it didn't affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant