fix: crash in KeyboardMovementObserver due to incorrect KVO removal
#787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report
|
kirillzyusko
added
🍎 iOS
kirillzyusko
deleted the
fix/crash-in-keybard-movement-observer-due-to-kvo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed a crash in
KeyboardMovementObserverdue to incorrect KVO removal.💡 Motivation and Context
Similar to #768
Instead of using plain KVO we are using block-scoped KVO, mainly to prevent random crashes, when we try to remove a KVO from a view that doesn't have it.
I can not 100% gurantee, that crash will not happen again, because a crash was very random and we can not reproduce it ourself (we just see it in Sentry) - so basically I can not test it.
But I'm pretty confident, that a new approach will fix the issue, since we will not accidentally remove KVO where it doesn't exist (because of block-scoped approach) 🤞
Also new approach reduces code duplication (such as
if keyPath == "center") and reduces a number of code lines 👀Fixes #152 (comment)
📢 Changelog
iOS
KeyboardMovementObserver;🤔 How Has This Been Tested?
Tested manually on iPhone 15 Pro (iOS 17.5).
📸 Screenshots (if appropriate):
trimmed-kvo-new-approach.mp4
📝 Checklist