Calculate correct position with comments before the package keyword #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect the file beginning by using `pass.Fset.File(f.Pos())` instead of assuming that `f.Pos()` is always the beginning of the file. `f.Pos()` is not the beginning of the file when there is for instance a comment before the package, which can lead to wrong reportings of the actual error position. Signed-off-by: Roman Mohr <rmohr@google.com>
|
@maiqueb FYI |
|
@kisielk thanks for maintaining this great linter. |
|
Looks good to me, can't believe it's been unreported for so long :) |
|
@kisielk would you be willing to create a release container this fix ? We're keen on it for kubevirt/kubevirt#8058 |
|
@maiqueb I just created v1.6.2 which contains the fix. Thanks |
Thank you :) Highly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect the file beginning by using
pass.Fset.File(f.Pos())instead ofassuming that
f.Pos()is always the beginning of the file.f.Pos()is the position of the package keyword which does not always correlate with the beginning of the file.f.Pos()is not the beginning of the file when there is for instance acomment before the package, which can lead to wrong reportings of the
actual error position.