-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fish support #260
Fish support #260
Conversation
Well... Local test run looks much better. I think I should check travis fish version/installation. Mine is |
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 88.03% 88.12% +0.09%
==========================================
Files 6 6
Lines 660 665 +5
==========================================
+ Hits 581 586 +5
Misses 79 79
Continue to review full report at Codecov.
|
1067e65
to
a5e8b36
Compare
c406d8c
to
a4a1fd9
Compare
@kislyuk Could you please take a look? I also have to unlock xcode version (may be it should be locked on |
This looks great! I'm not a fish user, but I'd be happy to take a look at this when I can find some spare time (though unfortunately that may not be for a while). I can at least comment on the xcode problem - I added that line based on the advice in this issue because OSX builds were broken. If the builds are working again without it, it's fine to remove. |
This would be a life saver. Is any help needed? |
Sorry about the delay, didn't notice this was ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! I don't think I have any issues to raise at all.
I don't think we need to configure the OS X build beyond the defaults if it works. |
I'm waiting for tests to pass on master, then I will roll a release. |
Now released in v1.10.0. I'm not an active fish user, so please test this release for me. @volkov thanks again for your work on this and apologies for the delays here. |
Issue #68 work in progress.
Struck with problem of getting current process cursor position superuser.
Also some tests are broken (currently ignored or added to "expected failures").