Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish support #260

Merged
merged 1 commit into from
May 12, 2019
Merged

Fish support #260

merged 1 commit into from
May 12, 2019

Conversation

volkov
Copy link
Contributor

@volkov volkov commented Jan 5, 2019

Issue #68 work in progress.

Struck with problem of getting current process cursor position superuser.

Also some tests are broken (currently ignored or added to "expected failures").

@volkov volkov changed the title Feature/fishsupport Feature/fishsupport #68 Jan 5, 2019
@volkov
Copy link
Contributor Author

volkov commented Jan 5, 2019

Well... Local test run looks much better. I think I should check travis fish version/installation. Mine is 2.7.1

@volkov volkov changed the title Feature/fishsupport #68 Fish support Jan 5, 2019
@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #260 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   88.03%   88.12%   +0.09%     
==========================================
  Files           6        6              
  Lines         660      665       +5     
==========================================
+ Hits          581      586       +5     
  Misses         79       79
Impacted Files Coverage Δ
argcomplete/shellintegration.py 100% <100%> (ø) ⬆️
argcomplete/__init__.py 90.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4d3c6...a4a1fd9. Read the comment docs.

@volkov
Copy link
Contributor Author

volkov commented Mar 5, 2019

@kislyuk Could you please take a look?

I also have to unlock xcode version (may be it should be locked on xcode 9.4?) and change pip install to python -m pip install to pass build.

@evanunderscore
Copy link
Collaborator

This looks great! I'm not a fish user, but I'd be happy to take a look at this when I can find some spare time (though unfortunately that may not be for a while).

I can at least comment on the xcode problem - I added that line based on the advice in this issue because OSX builds were broken. If the builds are working again without it, it's fine to remove.

@marcoesposito1988
Copy link

This would be a life saver.

Is any help needed?

@kislyuk
Copy link
Owner

kislyuk commented May 12, 2019

Sorry about the delay, didn't notice this was ready for review.

Copy link
Owner

@kislyuk kislyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! I don't think I have any issues to raise at all.

@kislyuk kislyuk merged commit 68b06d7 into kislyuk:master May 12, 2019
@kislyuk
Copy link
Owner

kislyuk commented May 12, 2019

I don't think we need to configure the OS X build beyond the defaults if it works.

@kislyuk
Copy link
Owner

kislyuk commented May 12, 2019

I'm waiting for tests to pass on master, then I will roll a release.

@kislyuk
Copy link
Owner

kislyuk commented May 12, 2019

Now released in v1.10.0. I'm not an active fish user, so please test this release for me.

@volkov thanks again for your work on this and apologies for the delays here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants