Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use tempfiles for IPC #307

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

evanunderscore
Copy link
Collaborator

Supersedes #306, fixes #267, fixes #142.

Adds support for Git Bash (and potentially other shells on Windows) by giving the option to use a file for IPC instead of file descriptors.

Currently this feature is opt-in as described in the README.

@evanunderscore
Copy link
Collaborator Author

@kislyuk Given the lengthy discussion on this so far, I'll leave this to you to approve and merge. If you prefer, I can make this the default on Windows instead of being opt-in.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #307 into master will decrease coverage by 0.39%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   82.72%   82.32%   -0.40%     
==========================================
  Files           7        7              
  Lines         741      747       +6     
==========================================
+ Hits          613      615       +2     
- Misses        128      132       +4     
Impacted Files Coverage Δ
argcomplete/shell_integration.py 100.00% <ø> (ø)
argcomplete/__init__.py 90.35% <33.33%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ce077...9f90359. Read the comment docs.

@kislyuk kislyuk merged commit d504584 into kislyuk:master Jul 8, 2020
@kislyuk
Copy link
Owner

kislyuk commented Jul 8, 2020

Thanks @evanunderscore for sticking with the long development cycle for this.

@evanunderscore
Copy link
Collaborator Author

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git bash for Windows support Anyone got this working with bash from git for windows?
3 participants