Ensure ZSH-related tests succeed when TERM variable is set to linux #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the test-suite with TERM=linux causes the ZSH related tests to fail. Fixed by hardcoding TERM="" when running the ZSH tests. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
While bash only has a single option for disabling bashrc loading, ZSH comes with two options: one for $HOME/.zshrc and one for the global zshrc (typically located in /etc). Pass both options to avoid surprises. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
testsuite-TERM=linux
branch
from
ecd846c
to
0981e74
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZSH tests are failing in the Ubuntu test infrastructure because the TERM variable is set to "linux". Ensure that the test-suite does not fail in this scenario.
I also added the --no-globalrcs option to the zsh invocation ; since --no-rcs only disables loading of $HOME/.zshrc
refs #496