code

kitajs · Jan 13, 2025 · cbddad7 · cbddad7
1 parent 10c9e2f
commit cbddad7
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/.changeset/happy-birds-breathe.md b/.changeset/happy-birds-breathe.md
@@ -0,0 +1,5 @@
+---
+'@kitajs/html': patch
+---
+
+Allow undefined in style attributes
diff --git a/packages/html/index.js b/packages/html/index.js
@@ -264,6 +264,10 @@ function attributesToString(attributes) {
     // @ts-expect-error - this indexing is safe.
     value = attributes[key];
 
+    if (value === null || value === undefined) {
+      continue;
+    }
+
     // React className compatibility.
     if (key === 'className') {
       // @ts-expect-error - both were provided, so use the class attribute.
@@ -317,10 +321,6 @@ function attributesToString(attributes) {
       continue;
     }
 
-    if (value === null || value === undefined) {
-      continue;
-    }
-
     result += ' ' + key;
 
     if (type !== 'string') {

diff --git a/packages/html/test/style.test.tsx b/packages/html/test/style.test.tsx
@@ -15,6 +15,15 @@ describe('Style', () => {
     );
   });
 
+  test('accepts undefined', () => {
+    assert.equal(
+      <div style={{ backgroundColor: undefined }}></div>,
+      '<div style=""></div>'
+    );
+
+    assert.equal(<div style={undefined}></div>, '<div></div>');
+  });
+
   test('CSSProperties', () => {
     const style: JSX.CSSProperties = {
       color: 'red',