Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect unmatched tokens #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stereosteve
Copy link

Hello Kaspar,

One thing that might be nice is the ability to collect the extraneous tokens, so that if user enters 100nF 0603 50V Kemet, the Kemet token could be used for full text search.

This is a pretty hack-y way to do it, and it breaks the return behavior of {} for no match. I've not used Nearly before, so believe there is probably a better way to do this, but thought I would create PR just to get your thoughts.

@kasbah
Copy link
Member

kasbah commented Aug 24, 2018

Hi Steve, I was playing around with something similar quite a while back on the return-ignored branch. It did what you implemented but also checked if any input caused no change to the output. I believe it still fails on some edge cases.

There is a demo up as well. Should have opened a pull-request for visibility. The way you just add it as a prop on the return object is neater more backwards compatible than what I did though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants