Allow wiggle room in SI prefixes that won't be ambiguous #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, could you add a test or two and re-build the demo site please. |
|
Will do as soon as I'm on desktop. Seems this has been done in the antlr branch. Not sure I yet understand if/how these two ports will relate and coexist together. Will have to dig into docs later :) |
|
Thanks, Antlr branch is work in progress but has been for a while now. It's fine to improve the current master branch. Test additions are especially important as when we do switch to Antlr we will re-use the test suite to make sure we aren't introducing regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18
Untested :)