WIP: Port to Antlr4 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kasbah
force-pushed
the
antlr
branch
8 times, most recently
from
f95d073
to
38d8465
Compare
Renames characteristic -> dielectric. Renames size -> package_size. Only uses reasonable units (1F -> 1uF). Uncomments tests that fail because of tolerance position.
Test suite, more package names
|
@kasbah Mmh not sure why it's failing the style checker. When I run them on my computer the git diff is empty. I'm also not sure why it passed with that semicolon before, since it's been there for a while... |
|
There was a diff in the package-lock.json. I fixed this by commiting the yarn.lock so travis will use yarn. I use yarn myself anyway. Do you mind using it? |
|
Nope, don't mind
On Feb 4, 2018 16:42, "Kaspar Emanuel" <notifications@github.com> wrote:
There was a diff in the package-lock.json. I fixed this by commiting the
yarn.lock so travis will use yarn. I use yarn myself anyway. Do you mind
using it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtRrx4ZEg46-Kdersofe2whOv6Ehy3Nks5tRc_bgaJpZM4Rl65T>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things required to merge this: