Lower dependency count #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are removing OpenTelemetry for now :( |
|
Actually, I have an idea.. this will be hacky. |
|
Okay, that should be fine. Patched every OpenTelemetry dependency and the tonic dependency.. geez. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just gets rid of some dependencies across the workspace to slim down the gigantic dependency tree.
Open question:
tonicwas upgraded to http v1, which is one of the sources of the most duplicate dependencies at the moment (see Upgrade to Hyper 1.0 & Axum 0.7 hyperium/tonic#1670 and Upgrade to hyper/http v1.0 open-telemetry/opentelemetry-rust#1674)