Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set timeout for GitHub GraphQL API #582

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Set timeout for GitHub GraphQL API #582

merged 1 commit into from
Nov 29, 2024

Conversation

kitsuyui
Copy link
Owner

There was no timeout setting, and even if an error occurred, only No data found was output.
This is the worst user interface and makes debugging difficult.
Resolve this.

There was no timeout setting, and even if an error occurred, only No data found was output.
This is the worst user interface and makes debugging difficult.
Resolve this.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 76.38%. Comparing base (f829665) to head (bbf5fe2).

Files with missing lines Patch % Lines
src/github/api.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   77.00%   76.38%   -0.62%     
==========================================
  Files          19       19              
  Lines        1857     1872      +15     
==========================================
  Hits         1430     1430              
- Misses        427      442      +15     
Flag Coverage Δ
unittests 76.38% <0.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitsuyui kitsuyui merged commit d66797c into main Nov 29, 2024
18 checks passed
@kitsuyui kitsuyui deleted the set-timeout branch November 29, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants