Switch to monorepo #321
Merged
Switch to monorepo #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kitsuyui
commented
Jan 20, 2024
kitsuyui
commented
- Add pnpm-workspace.yaml
- Move current project items into packages/simple/
- Install turborepo
kitsuyui
force-pushed
the
monorepo
branch
5 times, most recently
from
414ae29 to
24cbd25
Compare
- Add pnpm-workspace.yaml - Move current project items into packages/simple/ - Install turborepo
kitsuyui
added a commit
that referenced
this pull request
Feb 2, 2024
I forgot to add the workspaces field to package.json in #321 . So Renovate didn't pick up the change in monorepo configurations properly and causes the build to fail. ``` ERR_PNPM_OUTDATED_LOCKFILE Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with packages/simple/package.json ``` This commit adds the workspaces field to package.json and updates pnpm-lock.yaml accordingly.
kitsuyui
added a commit
that referenced
this pull request
Jan 4, 2025
When I migrated to monorepo in #321, I should have removed the lock files that were no longer in use. It is sufficient to have the lock file in the package root of the monorepo, so the lock files other than that should be removed.
Merged
kitsuyui
added a commit
that referenced
this pull request
Jan 4, 2025
When I migrated to monorepo in #321, I should have removed the lock files that were no longer in use. It is sufficient to have the lock file in the package root of the monorepo, so the lock files other than that should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.