Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClearButton to TextField #279

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add ClearButton to TextField #279

merged 3 commits into from
Dec 4, 2023

Conversation

kitsuyui
Copy link
Owner

@kitsuyui kitsuyui commented Dec 2, 2023

Implement only the function without setting CSS etc.

@kitsuyui kitsuyui changed the title Add ResetButton to TextField Add ClearButton to TextField Dec 4, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (99dca13) 62.73% compared to head (9db4c23) 68.85%.
Report is 78 commits behind head on main.

Files Patch % Lines
packages/treemap/src/treemap.tsx 0.00% 18 Missing ⚠️
packages/textfield/src/TextArea.tsx 77.55% 11 Missing ⚠️
packages/textfield/src/TextField.tsx 77.08% 11 Missing ⚠️
packages/editablelabel/src/EditableLabel.tsx 91.66% 4 Missing ⚠️
packages/textfield/src/ClearButtonProvider.tsx 93.22% 4 Missing ⚠️
packages/dekamoji/src/dekamoji.tsx 85.71% 2 Missing ⚠️
packages/style-bulma/src/timer.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   62.73%   68.85%   +6.12%     
==========================================
  Files          30       35       +5     
  Lines        1119     1249     +130     
  Branches      201      218      +17     
==========================================
+ Hits          702      860     +158     
+ Misses        417      389      -28     
Flag Coverage Δ
unittests 68.85% <79.43%> (+6.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitsuyui kitsuyui merged commit 48c2142 into main Dec 4, 2023
19 checks passed
@kitsuyui kitsuyui deleted the text-field-with-reset-button branch December 4, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants