Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CI send coverage condition #296

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Fix: CI send coverage condition #296

merged 1 commit into from
Jan 20, 2024

Conversation

kitsuyui
Copy link
Owner

  • pull-request events are not triggered when a PR is merged
  • push events are not triggered when a PR created from a fork repository
  • So we need both to run tests on every PR and after merging

- pull-request events are not triggered when a PR is merged
- push events are not triggered when a PR created from a fork repository
- So we need both to run tests on every PR and after merging
@codecov-commenter
Copy link

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (99dca13) 62.73% compared to head (88034f3) 68.99%.
Report is 111 commits behind head on main.

Files Patch % Lines
packages/binary/src/Detailed.tsx 34.37% 21 Missing ⚠️
packages/treemap/src/treemap.tsx 0.00% 18 Missing ⚠️
packages/textfield/src/TextArea.tsx 80.76% 10 Missing ⚠️
packages/textfield/src/TextField.tsx 80.00% 10 Missing ⚠️
packages/editablelabel/src/EditableLabel.tsx 91.66% 4 Missing ⚠️
packages/style-bulma/src/timer.tsx 33.33% 4 Missing ⚠️
packages/textfield/src/ClearButtonProvider.tsx 93.44% 4 Missing ⚠️
packages/dekamoji/src/dekamoji.tsx 80.00% 3 Missing ⚠️
packages/binary/src/Simple.tsx 75.00% 2 Missing ⚠️
packages/style-bulma/src/stopwatch.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   62.73%   68.99%   +6.26%     
==========================================
  Files          30       39       +9     
  Lines        1119     1329     +210     
  Branches      201      243      +42     
==========================================
+ Hits          702      917     +215     
+ Misses        417      412       -5     
Flag Coverage Δ
unittests 68.99% <76.64%> (+6.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitsuyui kitsuyui merged commit 8dc3e56 into main Jan 20, 2024
20 checks passed
@kitsuyui kitsuyui deleted the fix-ci-send-coverage branch January 20, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants