-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Analog Clock UI #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
===========================================
+ Coverage 64.78% 82.80% +18.01%
===========================================
Files 5 9 +4
Lines 71 157 +86
Branches 7 11 +4
===========================================
+ Hits 46 130 +84
- Misses 19 21 +2
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Currently, there is only a minimal UI, so add UI. However, I don't want to use CSS frameworks such as Tailwind, Bulma, and UI Kit. I want to keep it within the range of bare functions supported by the browser. Or, take one of the following options 1. Do not directly depend on parts that depend on CSS frameworks, but keep them as indirect dependencies (optionalDependencies) 2. If you use a CSS framework, separate the parts that depend on the CSS framework into a separate package.
- Use monospace fonts. - remove borders.
kitsuyui
force-pushed
the
add-ui-variation
branch
from
May 23, 2023 19:24
199a091
to
52541c3
Compare
The threshold for snapshot testing is currently a perfect match. Relax it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is only a minimal UI, so add UI.
However, I don't want to use CSS frameworks such as Tailwind, Bulma, and UI Kit.
I want to keep it within the range of bare functions supported by the browser.
Or, take one of the following options
Analog Clock