Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Analog Clock UI #59

Merged
merged 12 commits into from
May 24, 2023
Merged

Update Analog Clock UI #59

merged 12 commits into from
May 24, 2023

Conversation

kitsuyui
Copy link
Owner

@kitsuyui kitsuyui commented May 20, 2023

Currently, there is only a minimal UI, so add UI.
However, I don't want to use CSS frameworks such as Tailwind, Bulma, and UI Kit.
I want to keep it within the range of bare functions supported by the browser.
Or, take one of the following options

  1. Do not directly depend on parts that depend on CSS frameworks, but keep them as indirect dependencies (optionalDependencies)
  2. If you use a CSS framework, separate the parts that depend on the CSS framework into a separate package.

Analog Clock

  • Lines
  • Faces
  • tick / sweep mode
  • roman / arabic mode
Screenshot 2023-05-24 at 4 19 53

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2023

Codecov Report

Patch coverage: 96.00% and project coverage change: +18.01 🎉

Comparison is base (c20a945) 64.78% compared to head (c20ca20) 82.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #59       +/-   ##
===========================================
+ Coverage   64.78%   82.80%   +18.01%     
===========================================
  Files           5        9        +4     
  Lines          71      157       +86     
  Branches        7       11        +4     
===========================================
+ Hits           46      130       +84     
- Misses         19       21        +2     
  Partials        6        6               
Flag Coverage Δ
unittests 82.80% <96.00%> (+18.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/simple/src/App.tsx 57.89% <ø> (ø)
packages/clock/src/digital.tsx 68.75% <83.33%> (ø)
packages/clock/src/analog.tsx 94.82% <94.64%> (-1.18%) ⬇️
packages/clock/src/faces/arabic/index.ts 100.00% <100.00%> (ø)
packages/clock/src/faces/index.ts 100.00% <100.00%> (ø)
packages/clock/src/faces/roman/index.ts 100.00% <100.00%> (ø)
packages/clock/src/step/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

kitsuyui added 7 commits May 24, 2023 01:44
Currently, there is only a minimal UI, so add UI.
However, I don't want to use CSS frameworks such as Tailwind, Bulma, and UI Kit.
I want to keep it within the range of bare functions supported by the browser.
Or, take one of the following options
1. Do not directly depend on parts that depend on CSS frameworks, but keep them as indirect dependencies (optionalDependencies)
2. If you use a CSS framework, separate the parts that depend on the CSS framework into a separate package.
- Use monospace fonts.
- remove borders.
@kitsuyui kitsuyui force-pushed the add-ui-variation branch from 199a091 to 52541c3 Compare May 23, 2023 19:24
@kitsuyui kitsuyui changed the title Add UI Update Analog Clock UI May 24, 2023
@kitsuyui kitsuyui merged commit 2779118 into main May 24, 2023
@kitsuyui kitsuyui deleted the add-ui-variation branch May 24, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants