Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GitHub Workflow trigger #20

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix: GitHub Workflow trigger #20

merged 1 commit into from
Aug 7, 2023

Conversation

kitsuyui
Copy link
Owner

@kitsuyui kitsuyui commented Aug 7, 2023

GitHub Workflow was triggered only when push event was fired.
Now it is also triggered when pull_request event is fired.
This enables external contributors to run tests when they send pull requests.
(push event is fired when push is done to forked repository, but push event is not fired when push is done to kitsuyui's repository)

GitHub Workflow was triggered only when push event was fired.
Now it is also triggered when pull_request event is fired.
This enables external contributors to run tests when they send pull requests.
(push event is fired when push is done to forked repository, but push event is not fired when push is done to kitsuyui's repository)
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 Happy commit!

  • Now pull request issue number reaches 20. It's time to celebrate!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (f32eae8) 94.39% compared to head (1d3bd0d) 94.39%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files           9        9           
  Lines         339      339           
=======================================
  Hits          320      320           
  Misses         19       19           
Flag Coverage Δ
unittests 94.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitsuyui kitsuyui merged commit 75f6113 into main Aug 7, 2023
@kitsuyui kitsuyui deleted the fix-github-actions-event branch August 7, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants