Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: deserialize nullability #56

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Fix: deserialize nullability #56

merged 1 commit into from
Jan 20, 2024

Conversation

kitsuyui
Copy link
Owner

  • Some fields are nullable, but the deserializer was not handling that
    correctly. This fixes that.

- Some fields are nullable, but the deserializer was not handling that
  correctly. This fixes that.
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6a436d9) 95.18% compared to head (ba90eb1) 95.28%.
Report is 13 commits behind head on main.

Files Patch % Lines
src/branch_detail.rs 98.03% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   95.18%   95.28%   +0.09%     
==========================================
  Files           9        9              
  Lines         395      445      +50     
==========================================
+ Hits          376      424      +48     
- Misses         19       21       +2     
Flag Coverage Δ
unittests 95.28% <98.52%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitsuyui kitsuyui merged commit 0f6fb9d into main Jan 20, 2024
9 checks passed
@kitsuyui kitsuyui deleted the fix-deserialize-nullability branch January 20, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants