Install oktokit in changelog workflow (arduino#901)

* install oktokit in changelog workflow * fix how the old changelog is cut off
kittaakos · Mar 14, 2022 · 61c2b1a · 61c2b1a
1 parent 8cac087
commit 61c2b1a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/compose-full-changelog.yaml b/.github/workflows/compose-full-changelog.yaml
@@ -32,6 +32,7 @@ jobs:
       - name: Create full changelog
         id: full-changelog
         run: |
+          yarn add @octokit/rest
           mkdir "${{ github.workspace }}/${{ env.CHANGELOG_ARTIFACTS }}"
 
           # Get the changelog file name to build

diff --git a/arduino-ide-extension/src/electron-main/ide-updater/ide-updater-impl.ts b/arduino-ide-extension/src/electron-main/ide-updater/ide-updater-impl.ts
@@ -81,11 +81,9 @@ export class IDEUpdaterImpl implements IDEUpdater {
           ? await fetch(`${CHANGELOG_BASE_URL}/${latestChangelogFileName}`)
           : null;
         const changelog = response?.ok ? await response?.text() : null;
-
+        const currentVersionHeader = `\n\n---\n\n## ${this.updater.currentVersion}\n\n`;
         // We only want to see the release notes of newer versions
-        const currentVersionIndex = changelog?.indexOf(
-          `\r\n\r\n---\r\n\r\n## ${this.updater.currentVersion}\r\n\r\n`
-        );
+        const currentVersionIndex = changelog?.indexOf(currentVersionHeader);
         const newChangelog =
           currentVersionIndex && currentVersionIndex > 0
             ? changelog?.slice(0, currentVersionIndex)