Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated unicorn sacrifice cannot keep up with production #192

Closed
1 of 3 tasks
ArcanErasmus opened this issue Mar 20, 2023 · 1 comment · Fixed by #411
Closed
1 of 3 tasks

Automated unicorn sacrifice cannot keep up with production #192

ArcanErasmus opened this issue Mar 20, 2023 · 1 comment · Fixed by #411
Assignees
@oliversalzburg
Labels
needs:merge This work has been completed. It needs to be merged prio:important Should be included in next release status:completed This needs no further attention type:bug Problems in existing behavior
Milestone
v2.0.0-beta.8

Comments

@ArcanErasmus
Copy link

Version Check

  • I have updated to v2.0.0-beta.7 or later.
  • I have updated to the nightly build from last night (or latest one available).
  • I have tested with the latest source code from main as of today.

What browser are you using?

Firefox, desktop, windows 10

How are you loading Kitten Scientists?

Userscript Manager (Tampermonkey)

Describe the Bug

Every tick of KS, a single "sacrifice unicorns" press is enacted, sacrificing 2500 unicorns. However, I produce unicorns far faster than this, so effectively my tears production is capped by KS's speed, regardless of actual unicorn production.

Your Savegame

Kittens Game.txt

To Reproduce

No response

Screenshots

image
Sacrifice Unicorns is enabled, threshold is at 1M

image
Wow, that's a lot of log messages (if only I could disable sacrifice messages...)!

image
And the number of Unicorns continues to climb, despite KS's best efforts!

btw thank you for your hard work maintaining KS!
@ArcanErasmus ArcanErasmus added needs:triage A developer needs to look at this type:bug Problems in existing behavior labels Mar 20, 2023
@oliversalzburg oliversalzburg added prio:important Should be included in next release needs:work It's clear what needs to be done. Now we need to do it status:confirmed A developer reproduced this issue and removed needs:triage A developer needs to look at this labels Mar 22, 2023
@oliversalzburg oliversalzburg added this to the v2.0-rc milestone Mar 22, 2023
@oliversalzburg oliversalzburg added the type:upstream-issue We need to fix this somewhere else label Mar 22, 2023
@oliversalzburg
Copy link
Member

Partially an upstream issue: https://bitbucket.org/bloodrizer/kitten-game/pull-requests/1172

Still needs a more optimized solution in KS.

@oliversalzburg oliversalzburg moved this from Todo to In Progress in Kitten Science Nov 17, 2023
oliversalzburg added a commit that referenced this issue Nov 17, 2023
@oliversalzburg
fix(religion): Unicorns are sacrificed too slowly
cf12b47 
Because we were only "clicking" the regular sacrifice button every iteration, we would always only sacrifice 2500 unicorns. But players often spawn far more unicorns than that in the same time, making them grow infinitely.

Fixes #192
@oliversalzburg oliversalzburg added needs:merge This work has been completed. It needs to be merged status:completed This needs no further attention and removed needs:work It's clear what needs to be done. Now we need to do it status:confirmed A developer reproduced this issue type:upstream-issue We need to fix this somewhere else labels Nov 17, 2023
@oliversalzburg oliversalzburg mentioned this issue Nov 17, 2023
Merged
oliversalzburg added a commit that referenced this issue Nov 18, 2023
@oliversalzburg
fix(religion): Unicorns are sacrificed too slowly
fe91da2 
Because we were only "clicking" the regular sacrifice button every iteration, we would always only sacrifice 2500 unicorns. But players often spawn far more unicorns than that in the same time, making them grow infinitely.

Fixes #192
oliversalzburg added a commit that referenced this issue Nov 18, 2023
@oliversalzburg
fix(religion): Unicorns are sacrificed too slowly
b7a54b0 
Because we were only "clicking" the regular sacrifice button every iteration, we would always only sacrifice 2500 unicorns. But players often spawn far more unicorns than that in the same time, making them grow infinitely.

Fixes #192
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kitten Science Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliversalzburg oliversalzburg

Labels
needs:merge This work has been completed. It needs to be merged prio:important Should be included in next release status:completed This needs no further attention type:bug Problems in existing behavior
Projects
Kitten Science
Archived in project
Milestone
v2.0.0-beta.8
Development

Successfully merging a pull request may close this issue.

fix(religion): Unicorns are sacrificed too slowly kitten-science/kitten-scientists
2 participants
@oliversalzburg @ArcanErasmus