Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savegame is lost regularly when using bookmarklet #806

Closed
3 tasks done
oliversalzburg opened this issue Dec 6, 2024 · 1 comment
Closed
3 tasks done

Savegame is lost regularly when using bookmarklet #806

oliversalzburg opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels
prio:important Should be included in next release status:completed This needs no further attention type:bug Problems in existing behavior
Milestone

Comments

@oliversalzburg
Copy link
Member

Version Check

  • I have updated to v2.0.0-beta.8 or later.
  • I have updated to the nightly build from last night (or latest one available).
  • I have tested with the latest source code from main as of today.

What browser are you using?

No response

How are you loading Kitten Scientists?

Bookmarklet

Describe the Bug

When you load the game and you don't load KS right away, KG will store a save without KS settings, losing all your settings.

This also happens when we break our infrastructure and people aren't able to load the bookmarklet.

Your Savegame

No response

To Reproduce

  1. Start KG
  2. Load KS through bookmarklet.
  3. Make changes to KS settings and save.
  4. Reload KG and wait for it to save, or save manually.
  5. Load KS - the settings will be empty.

Screenshots

No response

@oliversalzburg oliversalzburg added needs:work It's clear what needs to be done. Now we need to do it prio:important Should be included in next release status:inprogress Someone is actively working on this type:bug Problems in existing behavior labels Dec 6, 2024
@oliversalzburg oliversalzburg added this to the v2.0.0-beta.9 milestone Dec 6, 2024
@oliversalzburg oliversalzburg self-assigned this Dec 6, 2024
@oliversalzburg oliversalzburg moved this to In Progress in Kitten Science Dec 6, 2024
@oliversalzburg
Copy link
Member Author

Partially fixed by be9274e

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kitten Science Dec 8, 2024
@oliversalzburg oliversalzburg added status:completed This needs no further attention and removed needs:work It's clear what needs to be done. Now we need to do it status:inprogress Someone is actively working on this labels Dec 8, 2024
oliversalzburg added a commit that referenced this issue Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:important Should be included in next release status:completed This needs no further attention type:bug Problems in existing behavior
Projects
Archived in project
Development

No branches or pull requests

1 participant