Update for breaking change in django-allauth
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #188 |
mvandenburgh
added a commit
to dandi/dandi-archive
that referenced
this pull request
Sep 11, 2023
This should be removed once the corresponding fix upstream in `django-composed-confiugration` is merged. kitware-resonant/django-composed-configuration#189
This was referenced Sep 11, 2023
danlamanna
approved these changes
Sep 11, 2023
|
@zachmullen Please open a separate PR with this fix. It's unrelated to the PR here. |
zachmullen
force-pushed
the
add-allauth-middleware
branch
from
90dcc31
to
ff92cdd
Compare
brianhelba
reviewed
Oct 24, 2023
brianhelba
reviewed
Oct 24, 2023
brianhelba
reviewed
Oct 24, 2023
As of `django-allauth` 0.56.0, downstream users are required to specify this in their Django `MIDDLEWARE`. https://github.com/pennersr/django-allauth/blob/main/ChangeLog.rst#0560-2023-09-07
mvandenburgh
force-pushed
the
add-allauth-middleware
branch
from
ff92cdd
to
897a383
Compare
brianhelba
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
django-allauth0.56.0, downstream users are required to specify this in their DjangoMIDDLEWARE.See https://github.com/pennersr/django-allauth/blob/main/ChangeLog.rst#0560-2023-09-07.
Not specifying this middleware results in this error - https://stackoverflow.com/questions/77012106/django-allauth-modulenotfounderror-no-module-named-allauth-account-middlewar
Example of this error occuring in CI on DANDI - https://github.com/dandi/dandi-archive/actions/runs/6114588402/job/16596456625?pr=1674
Fixes #188