Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a test failure due to Django warnings #351

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

brianhelba
Copy link
Contributor

@brianhelba brianhelba commented Mar 15, 2024

This was caused by a change in pytest 8:

#9288: warns() now re-emits unmatched warnings when the context closes – previously it would consume all warnings, hiding those that were not matched by the function.

While this is a new feature, we announce it as a breaking change because many test suites are configured to error-out on warnings, and will therefore fail on the newly-re-emitted warnings.

@brianhelba brianhelba merged commit c7d23b7 into master Mar 15, 2024
6 checks passed
@brianhelba brianhelba deleted the test-warning branch March 15, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant