Sonobi Adapter - Added referrer param. Fixed timeout error in userSync (

prebid#2497)
kitwestneat · May 15, 2018 · d6788db · d6788db
1 parent 193ce63
commit d6788db
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 10 deletions.
diff --git a/modules/sonobiBidAdapter.js b/modules/sonobiBidAdapter.js
@@ -28,7 +28,7 @@ export const spec = {
     const bids = validBidRequests.map(bid => {
       let slotIdentifier = _validateSlot(bid);
       if (/^[\/]?[\d]+[[\/].+[\/]?]?$/.test(slotIdentifier)) {
-        slotIdentifier = slotIdentifier.charAt(0) === '/' ? slotIdentifier : '/' + slotIdentifier
+        slotIdentifier = slotIdentifier.charAt(0) === '/' ? slotIdentifier : '/' + slotIdentifier;
         return {
           [`${slotIdentifier}|${bid.bidId}`]: `${_validateSize(bid)}${_validateFloor(bid)}`
         }
@@ -41,7 +41,7 @@ export const spec = {
       }
     });
 
-    let data = {}
+    let data = {};
     bids.forEach((bid) => { Object.assign(data, bid); });
 
     const payload = {
@@ -57,6 +57,9 @@ export const spec = {
     if (validBidRequests[0].params.hfa) {
       payload.hfa = validBidRequests[0].params.hfa;
     }
+    if (validBidRequests[0].params.referrer) {
+      payload.ref = validBidRequests[0].params.referrer;
+    }
 
     // If there is no key_maker data, then dont make the request.
     if (isEmpty(data)) {
@@ -132,17 +135,21 @@ export const spec = {
    */
   getUserSyncs: (syncOptions, serverResponses) => {
     const syncs = [];
-    if (syncOptions.pixelEnabled && serverResponses[0].body.sbi_px) {
-      serverResponses[0].body.sbi_px.forEach(pixel => {
-        syncs.push({
-          type: pixel.type,
-          url: pixel.url
+    try {
+      if (syncOptions.pixelEnabled) {
+        serverResponses[0].body.sbi_px.forEach(pixel => {
+          syncs.push({
+            type: pixel.type,
+            url: pixel.url
+          });
         });
-      });
+      }
+    } catch (e) {
+      logError(e)
     }
     return syncs;
   }
-}
+};
 
 function _validateSize (bid) {
   if (bid.params.sizes) {
@@ -171,7 +178,7 @@ const _creative = (mediaType) => (sbi_dc, sbi_aid) => {
   }
   const src = 'https://' + sbi_dc + 'apex.go.sonobi.com/sbi.js?aid=' + sbi_aid + '&as=null' + '&ref=' + getTopWindowLocation().host;
   return '<script type="text/javascript" src="' + src + '"></script>';
-}
+};
 
 function _videoCreative(sbi_dc, sbi_aid) {
   return `https://${sbi_dc}apex.go.sonobi.com/vast.xml?vid=${sbi_aid}&ref=${getTopWindowLocation().host}`

diff --git a/test/spec/modules/sonobiBidAdapter_spec.js b/test/spec/modules/sonobiBidAdapter_spec.js
@@ -107,6 +107,7 @@ describe('SonobiBidAdapter', () => {
         'placement_id': '1a2b3c4d5e6f1a2b3c4d',
         'sizes': [[300, 250], [300, 600]],
         'floor': '1.25',
+        'referrer': 'overrides_top_window_location'
       },
       'adUnitCode': 'adunit-code-1',
       'sizes': [[300, 250], [300, 600]],
@@ -117,6 +118,7 @@ describe('SonobiBidAdapter', () => {
       'params': {
         'ad_unit': '/7780971/sparks_prebid_LB',
         'sizes': [[300, 250], [300, 600]],
+        'referrer': 'overrides_top_window_location'
       },
       'adUnitCode': 'adunit-code-2',
       'sizes': [[120, 600], [300, 600], [160, 600]],
@@ -139,6 +141,7 @@ describe('SonobiBidAdapter', () => {
       expect(bidRequests.data.pv).to.equal(bidRequestsPageViewID.data.pv)
       expect(bidRequests.data.hfa).to.not.exist
       expect(bidRequests.bidderRequests).to.eql(bidRequest);
+      expect(bidRequests.data.ref).to.equal('overrides_top_window_location');
       expect(['mobile', 'tablet', 'desktop']).to.contain(bidRequests.data.vp);
     })
 
@@ -281,6 +284,9 @@ describe('SonobiBidAdapter', () => {
         url: 'https://pixel-test'
       }]);
     })
+    it('should return an empty array when sync is enabled but there are no bidResponses', () => {
+      expect(spec.getUserSyncs({ pixelEnabled: true }, [])).to.have.length(0);
+    })
 
     it('should return an empty array when sync is enabled but no sync pixel returned', () => {
       const pixel = Object.assign({}, bidResponse);