Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pygmo to requirements-dev #120

Merged
merged 1 commit into from
May 25, 2020
Merged

Conversation

timokau
Copy link
Collaborator

@timokau timokau commented May 22, 2020

Description

Pulled out of #118, since it unbreaks travis and is also impacting other PRs (#119).

Forgotten in b031340. Hopefully fixes
the tests on travis, which currently fail because pygmo isn't getting
installed. The travis test script installs dependencies from
requirements-dev.txt.

Motivation and Context

Checks on travis are broken due to a missing dependency.

How Has This Been Tested?

Fixed travis on #118.

Does this close/impact existing issues?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Forgotten in b031340. Hopefully fixes
the tests on travis, which currently fail because pygmo isn't getting
installed. The travis test script installs dependencies from
requirements-dev.txt.
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files         116      116           
  Lines        7656     7656           
=======================================
  Hits         4608     4608           
  Misses       3048     3048           

@kiudee kiudee self-requested a review May 25, 2020 09:38
@kiudee kiudee merged commit 1311bcb into kiudee:master May 25, 2020
@timokau timokau deleted the add-pygmo-dev-dep branch May 25, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants