Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The next part in the #116 saga: I'm starting to remove instance attributes that are not parameters. The first one is
instance_thresholds
, which doesn't look like a useful feature to me. There is two distinct use cases, one simply reduces the dataset size and the other picks a simpler model. I have removed the first and replaced the second by an explicit parameter.Motivation and Context
Less surprising behavior and #116.
How Has This Been Tested?
Test suite and lints.
Does this close/impact existing issues?
Types of changes
Checklist: