Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some warnings #75

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Ignore some warnings #75

merged 1 commit into from
Nov 18, 2019

Conversation

timokau
Copy link
Collaborator

@timokau timokau commented Nov 14, 2019

Description

We do not have control about any of these warnings except the last one.
And that one is harmless in a testing context.

Maintaining a list of these filters is cumbersome. I wish there was some
way to automatically ignore all warnings caused by third party code, but
unfortunately I don't think there currently is. I've opened
pytest-dev/pytest#6191
to discuss this.

I still think it is worthwhile to filter these warnings, because
otherwise they drown out those warnings that are actually relevant.

How Has This Been Tested?

Ran all tests.

Does this close/impact existing issues?

Related to #59.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@timokau
Copy link
Collaborator Author

timokau commented Nov 14, 2019

Remaining warnings are the scikit-optimize warning that cannot currently be filtered, #72, #73 and #74.

@coveralls
Copy link

coveralls commented Nov 14, 2019

Pull Request Test Coverage Report for Build 577

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.548%

Totals Coverage Status
Change from base Build 574: 0.0%
Covered Lines: 9346
Relevant Lines: 23049

💛 - Coveralls

Copy link
Owner

@kiudee kiudee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a good idea to silence some of the warnings out of our control.
Other than the two typos, this looks ready to be merged.

pytest.ini Outdated Show resolved Hide resolved
pytest.ini Outdated Show resolved Hide resolved
We do not have control about any of these warnings except the last one.
And that one is harmless in a testing context.

Maintaining a list of these filters is cumbersome. I wish there was some
way to automatically ignore all warnings caused by third party code, but
unfortunately I don't think there currently is. I've opened
pytest-dev/pytest#6191
to discuss this.

I still think it is worthwhile to filter these warnings, because
otherwise they drown out those warnings that are actually relevant.
@timokau
Copy link
Collaborator Author

timokau commented Nov 18, 2019

Great! I've fixed the typos.

@kiudee kiudee self-requested a review November 18, 2019 08:33
@kiudee kiudee merged commit e1ce0b5 into kiudee:master Nov 18, 2019
@timokau timokau deleted the ignore-warnings branch November 18, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants