Use correct type for C enumerations #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The storage type of an enum can be any integer type big enough to cover the required range. Use the '#type' keyword of c2hs to derive the correct storage type for the cmark_node_type enumeration. Note that the previous use of CUShort produced incorrect results in big endian architectures where 'sizeof(cmark_node_type) > sizeof(CUShort)'. Signed-off-by: Ilias Tsitsimpis <iliastsi@debian.org>
Closed
|
Thank you, here is a test build on Fedora ppc64 and s390x: |
|
Awesome! Thank you so much! |
|
I’ll make a new release of this tomorrow ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage type of an enum can be any integer type big enough to cover
the required range. Use the '#type' keyword of c2hs to derive the
correct storage type for the cmark_node_type enumeration.
Note that the previous use of CUShort produced incorrect results in big
endian architectures where 'sizeof(cmark_node_type) > sizeof(CUShort)'.
Closes #6: not big-endian-safe
Signed-off-by: Ilias Tsitsimpis iliastsi@debian.org