[skip test] Release v0.23.0 #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
silverpill
reviewed
May 8, 2024
| * Fix release workflows by @gjtorikian in https://github.com/kivikakk/comrak/pull/395 | ||
|
|
||
|
|
||
| **Full Changelog**: https://github.com/kivikakk/comrak/compare/v0.23.1-pre.3...v0.23.0 |
There was a problem hiding this comment.
- Changelog is meant to inform the users of the software about notable changes. However, this list seems to include many internal changes that are of little interest to the end users. Perhaps it can be filtered somehow? You may also find this document interesting: https://keepachangelog.com
- Many dependency version bumps. Has any consideration been given to MSRV? For example clap v4.5.4 requires Rust 1.74. What's the current MSRV policy of this project?
There was a problem hiding this comment.
Worth noting this isn't actually a real release — 0.23.0 was published a last week.
- Perhaps indeed! I make no promises here, it depends on the release engineer's energy levels. Mine are usually pretty low.
package.rust-versioncurrently says 1.62.1. I assume our CI workflow/Dependabot needs to be brought up to speed.
|
We're already at 0.23.0, so I'm going to close this! It triggered on the PR that merged the workflow itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated PR to build the latest changelog. Upon merging, a new release will be created and published to crates.io.
Due to security considerations, PRs created by GitHub Actions cannot be merged automatically. Please review the changes and merge the PR.
If you require the test suites to run, you can close the PR and reopen it to trigger those workflows.