-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitLab multiline alerts #521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run on Mon Jan 20 21:31:57 UTC 2025 |
Looking good! Have run fuzzing for a bit and will continue to do so, but I'm happy if you're happy. :) |
Yeah I feel good about. Also ran fuzzing for a couple hours 👍 So I'll merge. Maybe we can cut a release whenever you have some time. |
Will make one tonight or tomorrow! :) |
Thanks! 🙇♂️ |
mfontanini
added a commit
to mfontanini/presenterm
that referenced
this pull request
Jan 23, 2025
This adds supports for markdown alerts (github/gitlab style) as support for these was recently added to comrak. This for now looks close a block quote except it also contains a title colored the same color as the vertical bar prefix that shows up on the left of the block quote. See kivikakk/comrak#519 and kivikakk/comrak#521 for syntax but basically this: ```markdown > [!note] > this is a note > [!tip] > this is a tip > [!important] > this is important > [!warning] > this is warning! > [!caution] > this advises caution! >>> [!note] other title ez multiline >>> ``` Renders like this: ![image](https://github.com/user-attachments/assets/219024ae-b635-4bf2-87ba-e252b64ebd67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the extensions
alerts
andmultiline-block-quotes
are enabled, then we now recognize GitLab style multiline alerts. For examplewill behave the same as
This makes it easier to make an alert out of multiple paragraphs and blocks, in the same fashion as GitLab multiline block quotes