Rebuilt temperature and humidity monitoring to use updateValue method #…

…733
kiwi-cam · Sep 25, 2024 · 802d896 · 802d896
1 parent 4527409
commit 802d896
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+### Fixed
+ - refreshCharacteristic and value() were not updating the UI. Rebuilt to use updateValue method. (#733)
+
 ## [4.4.18 - 2024-08-08]
 ### Added
  - Added ping state change logging for troubleshooting

diff --git a/accessories/aircon.js b/accessories/aircon.js
@@ -424,6 +424,7 @@ class AirConAccessory extends BroadlinkRMAccessory {
 
     this.updateTemperatureUI();
     if (!config.isUnitTest) {setInterval(()=>{this.getCurrentTemperature(this.updateTemperatureUI.bind(this))}, config.temperatureUpdateFrequency * 1000)}
+    //if (!config.isUnitTest) {setInterval(this.updateTemperatureUI.bind(this), config.temperatureUpdateFrequency * 1000)}
   }
 
   onTemperature (temperature,humidity) {
@@ -617,8 +618,10 @@ class AirConAccessory extends BroadlinkRMAccessory {
     const { config, serviceManager } = this;
     const { noHumidity } = config;
 
-    serviceManager.refreshCharacteristicUI(Characteristic.CurrentTemperature);
-    if(!noHumidity){serviceManager.refreshCharacteristicUI(Characteristic.CurrentRelativeHumidity);}
+    //serviceManager.refreshCharacteristicUI(Characteristic.CurrentTemperature);
+    //if(!noHumidity){serviceManager.refreshCharacteristicUI(Characteristic.CurrentRelativeHumidity);}
+    serviceManager.updateCharacteristicUI(Characteristic.CurrentTemperature, this.state.currentTemperature);
+    if(!noHumidity){serviceManager.updateCharacteristic(Characteristic.CurrentRelativeHumidity, this.state.currentHumidity);}
   }
 
   getCurrentTemperature (callback) {

diff --git a/accessories/humidifier-dehumidifier.js b/accessories/humidifier-dehumidifier.js
@@ -202,7 +202,7 @@ class HumidifierDehumidifierAccessory extends FanAccessory {
     device.checkHumidity();
 
     this.updateHumidityUI();
-    if (!config.isUnitTest && !config.noHumidity) {setInterval(()=>{this.getCurrentHumidity(this.updateHumidityUI.bind(this))}, config.humidityUpdateFrequency * 1000)}
+    if (!config.isUnitTest && !config.noHumidity) {setInterval(this.updateHumidityUI.bind(this), config.humidityUpdateFrequency * 1000)}
   }
 
   onHumidity (temperature,humidity) {
@@ -426,7 +426,8 @@ class HumidifierDehumidifierAccessory extends FanAccessory {
   updateHumidityUI () {
     const { config, serviceManager } = this;
 
-    serviceManager.refreshCharacteristicUI(Characteristic.CurrentRelativeHumidity);
+    //serviceManager.refreshCharacteristicUI(Characteristic.CurrentRelativeHumidity);
+    serviceManager.updateCharacteristic(Characteristic.CurrentRelativeHumidity, this.state.currentHumidity);
   }
 
   getCurrentHumidity (callback) {

diff --git a/helpers/serviceManager.js b/helpers/serviceManager.js
@@ -19,12 +19,17 @@ class ServiceManager {
     this.service.setCharacteristic(characteristic, value);
   }
 
+  updateCharacteristic (characteristic, value) {
+    this.service.getCharacteristic(characteristic).updateValue(value);
+  }
+
   getCharacteristic (characteristic) {
     return this.service.getCharacteristic(characteristic)
   }
 
   refreshCharacteristicUI (characteristic) {
-    this.getCharacteristic(characteristic).value;
+    //Historically, we refreshed the UI using getValue(). This is being depricated and replaced by the parameter value, which unfortunately does not refresh the UI, instaed use updateCharacteristic(characteristic, value)
+    this.service.getCharacteristic(characteristic).value;
   }
 
   // Convenience