Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fan characteristic warning #639

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Fix fan characteristic warning #639

merged 1 commit into from
Aug 13, 2023

Conversation

dnicolson
Copy link

This pull request fixes the following warning:
This plugin generated a warning from the characteristic 'On': Characteristic not in required or optional characteristic section for service Fanv2. Adding anyway.. See https://homebridge.io/w/JtMGR for more info.

The Fanv2 service does not support this characteristic, the solution is to subclass from BroadlinkRMAccessory like the TVAccessory (https://github.com/kiwi-cam/homebridge-broadlink-rm/blob/d78bc1902e11bf64438c63ca7ba8a43fe094e921/accessories/tv.js) does.

This fixes the warning in #624 (comment).

@kiwi-cam kiwi-cam changed the base branch from master to beta August 10, 2023 22:21
@kiwi-cam
Copy link
Owner

@dnicolson Thanks for sorting out the re-base. As you can tell, I got distracted :-)

@kiwi-cam kiwi-cam merged commit e9c7757 into kiwi-cam:beta Aug 13, 2023
@kiwi-cam
Copy link
Owner

kiwi-cam commented Aug 14, 2023

Hi @dnicolson, Just to let you know, this failed a couple of quality checks. There are duplicate setSwitchState definitions and arp is undefined. I've fixed both in the new beta release: 047a21a.

@kiwi-cam kiwi-cam mentioned this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants