Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only hide text values on .placeholder redaction reason #856

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Only hide text values on .placeholder redaction reason #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Orbit/Components/TextLink.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public struct TextLink: UIViewRepresentable {
private let content: NSAttributedString

private func resolvedLinkColor(in environment: EnvironmentValues) -> UIColor {
if #available(iOS 14, *), environment.redactionReasons.isEmpty == false {
if #available(iOS 14, *), environment.redactionReasons.contains(.placeholder) {
return .clear
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Orbit/Support/TextFields/TextField.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public struct TextField: UIViewRepresentable, TextFieldBuildable {
}

private func resolvedTextColor(in environment: EnvironmentValues) -> UIColor {
if #available(iOS 14, *), environment.redactionReasons.isEmpty == false {
if #available(iOS 14, *), environment.redactionReasons.contains(.placeholder) {
return .clear
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Orbit/Support/TextFields/TextView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public struct TextView: UIViewRepresentable, TextFieldBuildable {
}

private func resolvedTextColor(in environment: EnvironmentValues) -> UIColor {
if #available(iOS 14, *), environment.redactionReasons.isEmpty == false {
if #available(iOS 14, *), environment.redactionReasons.contains(.placeholder) {
return .clear
}

Expand Down
Loading