Fix Product/Version references for TestRun / TestExecution in multiple pages #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the root cause of the bug is that the correct relationship here is TR -> Build -> Version which is independent of the relationship TP -> Product -> Version. WARNING: this is an API change which requires more patches! - Method ``TestRun.filter()`` no longer returns the field ``plan__product_version`` - Method ``TestRun.filter()`` no longer returns the field ``plan__product_version__value`` - Method ``TestRun.filter()`` now returns the new field ``build__version`` - Method ``TestRun.filter()`` now returns the new field ``build__version__value``
atodorov
force-pushed
the
fix_wrong_version_for_testrun_search_page
branch
2 times, most recently
from
4ef2028
to
042e9a6
Compare
the root cause of the bug is that the correct relationship here is TR -> Build -> Version -> Product which is independent of the relationship TP -> Product. WARNING: this is an API change which requires more patches! - Method ``TestRun.filter()`` no longer returns the field ``plan__product`` - Method ``TestRun.filter()`` now returns the new field ``build__version__product`
following the previous 2 patches for the Search Test Run page this commit applies similar changes to RPC queries used on Telemetry pages. All of these underlying queries operate on TestExecution and Product/Version information should be matched against what was stored in TestExecution->Build because it is more accurate over time, while TE->TR->TP->Product/Version is more likely to change in the future!
use the relationship TR->Build as the starting point because TR->Plan is much more likely to update its Product/Version values in the future. NOTE: the field `product_version` which is removed from tests doesn't make sense because neither the underlying forms, not the underlying models have such a field.
atodorov
force-pushed
the
fix_wrong_version_for_testrun_search_page
branch
from
042e9a6
to
97821d2
Compare
similar to previous commits use Product/Version values based on the Build a specific TestExecution status was recorded against instead of using values coming from TestRun->TestPlan which can change in the future. NOTE: execution.build is initialized with run.build and then may change its value if we're recording results against multiple builds inside the same TestRun. (For example mark some executions as PASS, others as FAIL; then update TR to a newer Build; retest and mark the FAIL results as PASS)
atodorov
force-pushed
the
fix_wrong_version_for_testrun_search_page
branch
from
97821d2
to
31932c8
Compare
atodorov
added a commit
to kiwitcms/trackers-integration
that referenced
this pull request
Jan 13, 2024
after latest changes in Kiwi TCMS, see: kiwitcms/Kiwi@48a33a7 kiwitcms/Kiwi#3439
atodorov
added a commit
to kiwitcms/trackers-integration
that referenced
this pull request
Jan 13, 2024
after latest changes in Kiwi TCMS, see: kiwitcms/Kiwi@48a33a7 kiwitcms/Kiwi#3439
atodorov
added a commit
to kiwitcms/trackers-integration
that referenced
this pull request
Jan 13, 2024
after latest changes in Kiwi TCMS, see: kiwitcms/Kiwi@48a33a7 kiwitcms/Kiwi#3439
atodorov
added a commit
to kiwitcms/github-app
that referenced
this pull request
Jan 14, 2024
after latest changes in Kiwi TCMS, see: kiwitcms/Kiwi@48a33a7 kiwitcms/Kiwi#3439
atodorov
added a commit
to kiwitcms/github-app
that referenced
this pull request
Jan 15, 2024
after latest changes in Kiwi TCMS, see: kiwitcms/Kiwi@48a33a7 kiwitcms/Kiwi#3439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main issue being that TestRun->Plan->Product may change over time b/c plans evolve and that will leads to inaccurate queries/display of historical data. This is addressed by using the information stored in TestRun->Build and TestExecution->Build which is much more stable over time and represents values at the time of test execution.