BUG: Test Cases are created for every new run

[atodorov]

For example:

https://tcms.kiwitcms.org/runs/188/
https://tcms.kiwitcms.org/runs/189/

Both have KiwiJsonRpcClientTest.loginWithCorrectCredentialsTest with ID 428 and 431

[atodorov]

More info:
TC with ID: 422-429 were the first to be created at the time when TR-188 was executed. These all look fine. All of these test cases have their tester set to kiwitcms-bot on the TestExecution objects used inside TR.

Then we have TR-189 with test cases 422-426, re-used because they were already in the database. For their test execution counterparts however Tester is set to None.

Next inside TR-189 we have 3 more test cases: 430-432, all of which are duplicating existing objects in the database.
430 duplicates 427
431 duplicates 428
432 duplicates 429

For all of these 3 Tester is again set to kiwitcms-bot as it should be.

[atodorov]

Note:
The problem is with how this library operates. We have 2 modules containing tests here and we don't loop over all of them at once but rather one after the other.

Once we've added the first few test cases to the TR on the first iteration then the second iteration will look for matching test cases only inside the TR and because the 2nd batch isn't found they will be created again.

This is inside TestDataEmitter.addTestResultsToRun, the first 5 lines before the for loop.