Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unable to open zim files on sd card in version 3.8.1 #3593

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3577

If the ManageExternalStorage permission has not been granted, introduce the request, particularly when accessing features that necessitate this permission, such as downloading ZIM files, selecting a ZIM file from storage via the file picker, and refreshing the list of available ZIM files in storage.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (323598f) 48.93% compared to head (e94afbe) 48.85%.
Report is 8 commits behind head on develop.

❗ Current head e94afbe differs from pull request most recent head 1b6be45. Consider uploading reports for the commit 1b6be45 to get more accurate results

Files Patch % Lines
...le/nav/destination/library/LocalLibraryFragment.kt 21.05% 12 Missing and 3 partials ⚠️
...e/nav/destination/library/OnlineLibraryFragment.kt 16.66% 7 Missing and 3 partials ⚠️
...wix/kiwixmobile/core/utils/SharedPreferenceUtil.kt 0.00% 6 Missing and 1 partial ⚠️
.../kiwixmobile/core/extensions/ActivityExtensions.kt 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3593      +/-   ##
=============================================
- Coverage      48.93%   48.85%   -0.09%     
- Complexity      1087     1090       +3     
=============================================
  Files            285      285              
  Lines          10495    10527      +32     
  Branches        1404     1409       +5     
=============================================
+ Hits            5136     5143       +7     
- Misses          4527     4548      +21     
- Partials         832      836       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review December 14, 2023 05:58
MohitMaliFtechiz added 2 commits December 14, 2023 07:51
* If the ManageExternalStorage permission has not been granted, introduce the request, particularly when accessing features that necessitate this permission, such as downloading ZIM files, selecting a ZIM file from storage via the file picker, and refreshing the list of available ZIM files in storage.
@kelson42
Copy link
Collaborator

Mergin, no time to wait more for a review unfortunatley.

@kelson42 kelson42 merged commit 2632a85 into develop Dec 14, 2023
7 of 8 checks passed
@kelson42 kelson42 deleted the Issue#3577 branch December 14, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to open zim files on sd card in version 3.8.1
2 participants