Introduced the disable external links option for custom apps. #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohitMaliFtechiz
force-pushed
the
Issue#3586
branch
from
203ee48 to
323598f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3595 +/- ##
=============================================
- Coverage 48.98% 48.93% -0.05%
+ Complexity 1092 1087 -5
=============================================
Files 285 285
Lines 10502 10495 -7
Branches 1406 1404 -2
=============================================
- Hits 5144 5136 -8
Misses 4527 4527
- Partials 831 832 +1 ☔ View full report in Codecov by Sentry. |
* We have introduced the option to disable external links for custom apps. If a custom app is configured not to display the external links popup, it will both hide the external links preference from settings and refrain from showing the external link popup when opening external links. Additionally, we have included relevant comments within the methods and code to provide developers with a clear understanding of the reasons behind these changes.
|
@gouri-panda Lack of time to wait and trivial PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3586
We have introduced the option to disable
external linksfor custom apps. If a custom app is configured not to display theexternal links popup, it will both hide theexternal linkspreference from settings and refrain from showing theexternal link popupwhen opening external links. Additionally, we have included relevant comments within the methods and code to provide developers with a clear understanding of the reasons behind these changes.