Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Made a small improvement to the sidebar entries for "About the app" and "Support app." #3602

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Dec 15, 2023

Fixes #3601

  • Enhanced the 'Support Kiwix' option, which is configurable in the navigation for custom apps. If the custom app is set to display the "Support" menu item in navigation, it will be shown; otherwise, it will be hidden from the app.
  • Replaced the "kiwix" and "the" prefixes in "Support kiwix" and "About the app" with the app name in the navigation.
Support Url configured Support Url not configured Kiwix App
Screenshot_20231215-161405_Dwds Screenshot_20231215-163753_Dwds Screenshot_20231215-163844_Kiwix
  • Increased timeout for waiting for the views in ZimHostFragmentTest since on Android 13 it takes more time to find the views.

Screenshot from 2023-12-15 18-57-23

…he app" and "Support app."

* Introduced the 'Support kiwix' option, which is configurable in the navigation for custom apps. If the custom app is set to display the "Support" menu item in navigation, it will be shown; otherwise, it will be hidden from the app.
* Replaced the "kiwix" and "the" prefixes in "Support kiwix" and "About the app" with the app name in the navigation.
@MohitMaliFtechiz MohitMaliFtechiz changed the title * Fixed: Made a small improvement to the sidebar entries for "About the app" and "Support app." Fixed: Made a small improvement to the sidebar entries for "About the app" and "Support app." Dec 15, 2023
…e on Android 13 it takes time to find the views.
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bd22da) 48.79% compared to head (dcc8a40) 49.04%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3602      +/-   ##
=============================================
+ Coverage      48.79%   49.04%   +0.25%     
- Complexity      1093     1095       +2     
=============================================
  Files            285      285              
  Lines          10567    10567              
  Branches        1413     1413              
=============================================
+ Hits            5156     5183      +27     
+ Misses          4571     4552      -19     
+ Partials         840      832       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

Trivial PR and we have to relase, merging.

@kelson42 kelson42 merged commit e33edbe into develop Dec 16, 2023
10 checks passed
@kelson42 kelson42 deleted the Issue#3601 branch December 16, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small improvement around sidebar entries "About app" and "Support app"
2 participants