Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable EdgeChromium in unit and UI tests when it's released, and available on Saucelabs #502

Closed
mossroy opened this issue May 19, 2019 · 0 comments
Closed

Enable EdgeChromium in unit and UI tests when it's released, and available on Saucelabs #502

mossroy opened this issue May 19, 2019 · 0 comments
Assignees
@mossroy
Labels
enhancement
Milestone
v3.2

Comments

@mossroy
Copy link
Contributor

mossroy commented May 19, 2019

In #499, I disabled latest Edge for unit and UI tests, while keeping some of them on Edge 44 (which is the current latest) and Edge 40 (which is the one used on Windows mobile).
The reason is I needed to disable some UI tests on Edge<=44, but did not find an easy way to know the version of the tested browser, at runtime.

When Microsoft releases the new Edge based on Chromium, we should re-enable latest Edge in .travis.yml (where it starts nightwatch).
It should behave like Chromium, so we will probably not need to disable any tests for it.
@mossroy mossroy added this to the v2.7 milestone May 19, 2019
@mossroy mossroy self-assigned this May 19, 2019
@mossroy mossroy modified the milestones: v2.8, v2.7 Jul 14, 2019
@mossroy mossroy modified the milestones: v2.7, v2.8 Mar 29, 2020
@mossroy mossroy modified the milestones: v2.8, v2.9 Jul 11, 2020
@Jaifroid Jaifroid modified the milestones: v3.0, v3.1 Oct 3, 2020
@Jaifroid Jaifroid mentioned this issue Nov 23, 2020
Merged
Krinkle added a commit to Krinkle/kiwix-js that referenced this issue Nov 28, 2020
@Krinkle
Re-enable unit tests in latest Edge
563a6f0 
The unit tests were implicitly disabled after
kiwix#499 due to an issue with
the UI tests found on an older Edge version that was the default
"edge" version on SauceLabs in May 2019 (not sure which version
that was, the last pre-Chromium Edge version was 44, which was
passing, so perhaps SauceLabs defaulted to a beta release or
a much older version like 15-18?)

Now that Edge uses Chromium, try re-enabling the unit tests there.

Fixes kiwix#502.
Krinkle added a commit that referenced this issue Nov 28, 2020
@Krinkle
Re-enable unit and UI tests in latest Edge
522a7db 
The tests were disabled after #499
due to an issue with the Edge version that was the default "edge" on
SauceLabs in May 2019 (not sure which version that was, the last pre-Chromium
Edge version was 44, which was passing, so perhaps SauceLabs defaulted
to a beta release, or used a much older version like 15-18?)

Now that Edge uses Chromium, try re-enabling the tests.

Fixes #502.
Krinkle added a commit that referenced this issue Nov 28, 2020
@Krinkle
Re-enable unit and UI tests in latest Edge
590bcfc 
The tests were disabled after #499
due to an issue with the Edge version that was the default "edge" on
SauceLabs in May 2019 (not sure which version that was, the last pre-Chromium
Edge version was 44, which was passing, so perhaps SauceLabs defaulted
to a beta release, or used a much older version like 15-18?)

Now that Edge uses Chromium, try re-enabling the tests.

Fixes #502.
@Jaifroid Jaifroid modified the milestones: v3.1, v3.2 Dec 6, 2020
@mossroy mossroy closed this as completed in 8b3a5c3 Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossroy mossroy

Labels
enhancement
Projects
None yet
Milestone
v3.2
Development

No branches or pull requests
2 participants
@mossroy @Jaifroid