-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the usage of libkiwix deprecated API #535
Conversation
In kiwix-tools, the deprecated libkiwix API was used only in
Regarding |
@veloman-yunkan It seems we can delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the redundant line at src/searcher/kiwix-search.cpp#L117 has shown by codefactor.io ?
Else we are good (No need to ask for a second review once it is fixed)
`kiwix-read` was a confusing tool. It was a loose equivalent of `kiwix-search --suggest` also able to work on old ZIM archives that didn't contain a title index. Its existence is not justified.
d648583
to
8b36e94
Compare
Done |
Fixes #533