Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

[ Patch ] : Fix new Dir viewer to properly work and display info #101

Merged
merged 5 commits into from
Dec 18, 2023
Merged

[ Patch ] : Fix new Dir viewer to properly work and display info #101

merged 5 commits into from
Dec 18, 2023

Conversation

kiyarose
Copy link
Owner

No description provided.

Update directory.html
dea6284 
Signed-off-by: Damian Swan AAHS <damian.swan36@altoonastudent.com>
@kiyarose kiyarose added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Dec 18, 2023
@kiyarose kiyarose self-assigned this Dec 18, 2023
@deepsource-autofix
style: format code with Prettier and StandardJS
4610c8b 
This commit fixes the style issues introduced in dea6284 according to the output
from Prettier and StandardJS.

Details: #101
@pr-explainer-bot PR Explainer Bot
Copy link

Pull Request Report

Greetings!

Hello there! I'm here to provide you with a report on the changes, suggestions, bugs, improvements, and a rating for the code in the pull request. Let's dive in!

Changes

  1. Updated the text of the first script button to "Creds Master File" at line 21.
  2. Updated the text of the second script button to "Onc Master File" at line 27.
  3. Added a link to the sources folder at line 32.
  4. Added a link to create a new credential file at line 34.
  5. Modified the text for modifying the Master files and added links to the "Creds" and "Oncs" files at line 36.
  6. Added a note about making a pull request for adding details to the master files at line 42.

Suggestions

  • Consider using more descriptive names for the script buttons to improve clarity and understanding.

Bugs

  • No bugs found.

Improvements

  • It would be helpful to add some comments or documentation to explain the purpose and functionality of the script buttons and the dropdowns.

Rating

I would rate the code a 7 out of 10 based on the following criteria:

  • Readability: The code is fairly readable, but could benefit from more descriptive names and comments. (7/10)
  • Performance: The code doesn't have any performance issues. (10/10)
  • Security: The code doesn't seem to have any security vulnerabilities. (10/10)

That's all for now! If you have any questions or need further assistance, feel free to reach out. Happy coding!

@kiyarose kiyarose changed the title [ Patch ] Fix new Dir viewer to properly work and display info [ Patch ] : Fix new Dir viewer to properly work and display info Dec 18, 2023
Damian Swan AAHS added 2 commits December 18, 2023 13:17
Remove unneccicary commment
02a8a4c 
Signed-off-by: Damian Swan AAHS <damian.swan36@altoonastudent.com>
Commit Dropdown patch 7
691cc24
@restyled-io restyled-io bot mentioned this pull request Dec 18, 2023
Closed
@deepsource-autofix
style: format code with Prettier and StandardJS
4a97def 
This commit fixes the style issues introduced in 691cc24 according to the output
from Prettier and StandardJS.

Details: #101
@kiyarose kiyarose marked this pull request as ready for review December 18, 2023 18:43
@kiyarose
Copy link
Owner Author

Overriding checks as deploy_preview is always going to fail due to earlier issue w/ Deepsource spaming firebase API.
deploy_live should work fine when merging Pipeline to main

@kiyarose kiyarose merged commit 45695b5 into pipeline Dec 18, 2023
7 of 9 checks passed
@kiyarose kiyarose deleted the DamianSwanAAJHS2-dirpatcht5 branch December 18, 2023 18:44
@kiyarose kiyarose mentioned this pull request Dec 18, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kiyarose kiyarose

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kiyarose