-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to allow user to configure floating window #71
add option to allow user to configure floating window #71
Conversation
Thanks for the PR! However, this defeats one principle of this plugin: all settings must be Jupynium's vim plugin version agnostic. The benefits of this approach are:
There are four things that should be modified from here.
|
We can also make the option grouped to the kernel hover just in case in the future there are different types of floating windows we may use, and different options that may be added for hover (like timeout etc.). And name it require("jupynium").setup({
kernel_hover = {
floating_win_opts = {
border = "rounded",
},
},
}) |
58d7776
to
af436ca
Compare
I'd prefer if we use Also, can you add |
I think it's ready to be merged if you have no more comments! |
all good from me |
I really appreciate this PR! |
Allow users to configure floating win for
:JupyniumKernelHover
by passingwin_options
key in setup