Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attach stderr to jupyter process #98

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

joh
Copy link
Contributor

@joh joh commented Oct 2, 2023

Without stderr, kernels fail to start and JupyniumStartSync times out.

fixes #97

Without stderr, kernels fail to start and JupyniumStartSync times out.

fixes kiyoon#97
@joh
Copy link
Contributor Author

joh commented Oct 2, 2023

Style should be fixed now :)

@kiyoon
Copy link
Owner

kiyoon commented Oct 2, 2023

Thanks a lot for the contribution! I didn't know this would make a difference but it seems it can fix many problems.

I saw different behaviour when using JupyniumStartAndAttachToServerInTerminal. I assume if you use this command this problem doesn't exist?

@kiyoon kiyoon merged commit bebd597 into kiyoon:master Oct 2, 2023
8 checks passed
@joh
Copy link
Contributor Author

joh commented Oct 2, 2023

You're right, with JupyniumStartAndAttachToServerInTerminal it works without the fix, presumably because then stderr is (implicitly) attached to the neovim buffer.

As a comparison, here's /proc/$NOTEBOOK_PID/fd/2 for the two variants:

With JupyniumStartAndAttachToServer:
lrwx------ 1 joh joh 64 Oct 2 23:29 2 -> 'socket:[5855810]'

With JupyniumStartAndAttachToServerInTerminal:
lrwx------ 1 joh joh 64 Oct 2 23:27 2 -> /dev/pts/15

Now with the fix applied, we have:
With JupyniumStartAndAttachToServer:
lrwx------ 1 joh joh 64 Oct 2 23:34 2 -> '/tmp/tmpi0a_ynrx (deleted)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel fails to start, resulting in timeout
2 participants