forked from Axelrod-Python/Axelrod
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix off by one errors and fix tests. #1
Open
drvinceknight
wants to merge
69
commits into
kjurgielajtis:master
Choose a base branch
from
Axelrod-Python:kjurgielajtis-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix off by one errors and fix tests. #1
drvinceknight
wants to merge
69
commits into
kjurgielajtis:master
from
Axelrod-Python:kjurgielajtis-master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(I have also run through the |
drvinceknight
force-pushed
the
kjurgielajtis-master
branch
from
January 22, 2019 10:01
a1cec29
to
d871bc1
Compare
* Clean up docstrings, to match parameter-listing to actual parameters. * Response to meatballs' feedback. * Added a get_memory_from_transitions function for FSM. * Change default verbosity of get_memory_from_transitions. * Fixed build error, and made less verbose. * Change the format of transitions in get_memory_from_transitions to dict. * Added types to get_memory_from_transitions. * Make ActionChains faster. * Replaced get_accessible_transitions with a much faster version. * Updated tests for new memory classifiers. * Fixed mypy and doctest errors. * Updated metastrategies for new finite set. * Moved blocks/added comments for readability. * More specific typing. * Responded to Marc's comments. * Import List from typing. * Change DefaultDict type and added tit_for_five_tat test. * Remove type on all_memits * Remove more typing. * Fixed type on longest_path argument. * Responding to Marc's comments. * Fixed Tuple annotation. * Add a memory test to default FSM test. * Responded to some of drvinceknight comments on memory depth. * Fixed some errors. * Moved FSM memory functions to separate top-level file compute_finite_state_machine_memory * Added additional topic documentation for FSM/memory. * Fix code in new documentation. * Move unit tests for compute FSM memory and add order_memit_tuple. * Minor changes to meta_strategies doc. * Update bibliography.rst * Undid changes to usually coop/def. Move to different commit. * Delete old comment. * Remove memory tests from FSM test file; these have already been copied. * Add memory library back into FSM test. * Minor fixes to compute memory tests.
MemoryDecay missing from the list of strategies
Hypothesis warnings and speed up some tests
History class
…_strategies.rst and _strategies.py
drvinceknight
force-pushed
the
kjurgielajtis-master
branch
from
April 9, 2019 11:50
a72f393
to
4c55971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kjurgielajtis here are some changes that: