Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off by one errors and fix tests. #1

Open
wants to merge 69 commits into
base: master
Choose a base branch
from

Conversation

drvinceknight
Copy link

@kjurgielajtis here are some changes that:

  • Fix an off by one error in the initial comparison;
  • Include a number of tests that check each specific condition.

@drvinceknight
Copy link
Author

(I have also run through the black autoformatter.)

gaffney2010 and others added 27 commits January 30, 2019 06:26
* Clean up docstrings, to match parameter-listing to actual parameters.

* Response to meatballs' feedback.

* Added a get_memory_from_transitions function for FSM.

* Change default verbosity of get_memory_from_transitions.

* Fixed build error, and made less verbose.

* Change the format of transitions in get_memory_from_transitions to dict.

* Added types to get_memory_from_transitions.

* Make ActionChains faster.

* Replaced get_accessible_transitions with a much faster version.

* Updated tests for new memory classifiers.

* Fixed mypy and doctest errors.

* Updated metastrategies for new finite set.

* Moved blocks/added comments for readability.

* More specific typing.

* Responded to Marc's comments.

* Import List from typing.

* Change DefaultDict type and added tit_for_five_tat test.

* Remove type on all_memits

* Remove more typing.

* Fixed type on longest_path argument.

* Responding to Marc's comments.

* Fixed Tuple annotation.

* Add a memory test to default FSM test.

* Responded to some of drvinceknight comments on memory depth.

* Fixed some errors.

* Moved FSM memory functions to separate top-level file compute_finite_state_machine_memory

* Added additional topic documentation for FSM/memory.

* Fix code in new documentation.

* Move unit tests for compute FSM memory and add order_memit_tuple.

* Minor changes to meta_strategies doc.

* Update bibliography.rst

* Undid changes to usually coop/def.  Move to different commit.

* Delete old comment.

* Remove memory tests from FSM test file; these have already been copied.

* Add memory library back into FSM test.

* Minor fixes to compute memory tests.
MemoryDecay missing from the list of strategies
Hypothesis warnings and speed up some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants